Closed arturo-seijas closed 5 months ago
Out of curiosity, may I know what data needs public access? (I'm wondering if - rather than exposing config - exposing @Property might be a handy way to expose things we want), LGTM!
Which property are you referring to?
Test coverage for 3999d34d1bff29755f5b57853cf663ffd18a30e8
Name Stmts Miss Branch BrPart Cover Missing
------------------------------------------------------------------------------
src/charm.py 269 10 80 5 96% 198, 205, 283-285, 322, 360, 411, 552-553
src/consts.py 5 0 0 0 100%
src/controller/__init__.py 1 0 0 0 100%
src/controller/endpoint_slice.py 56 4 10 4 88% 103, 127, 149, 169
src/controller/endpoints.py 34 1 6 0 92% 53
src/controller/ingress.py 104 8 44 4 89% 60, 80-81, 185, 262->273, 266-268, 271-272
src/controller/resource.py 54 1 9 1 97% 64
src/controller/secret.py 59 8 19 4 79% 53, 71-76, 106->111, 108-110, 111->104, 133, 162
src/controller/service.py 38 1 6 0 93% 51
src/exceptions.py 4 0 0 0 100%
src/ingress_definition.py 272 26 70 8 89% 41, 70, 174-178, 196, 315-316, 361, 373, 377, 393-394, 409-410, 435, 437, 462-463, 496-497, 504-506, 508
src/tls_relation.py 121 6 25 1 94% 123, 136-142
------------------------------------------------------------------------------
TOTAL 1017 65 269 27 92%
Static code analysis report
Run started:2024-05-07 08:58:05.922211
Test results:
No issues identified.
Code scanned:
Total lines of code: 4854
Total lines skipped (#nosec): 11
Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0
Run metrics:
Total issues (by severity):
Undefined: 0
Low: 0
Medium: 0
High: 0
Total issues (by confidence):
Undefined: 0
Low: 0
Medium: 0
High: 0
Files skipped (0):
Applicable spec:
Overview
Make NginxRouteRequirer public so that data contained in it can be accessed by the requirer charms
Rationale
N/A
Juju Events Changes
N/A
Module Changes
N/A
Library Changes
nginx_route.py
Checklist
src-docs
urgent
,trivial
,complex
)