canonical / notebook-operators

Charmed Jupyter Notebooks
Apache License 2.0
5 stars 9 forks source link

Explore how the PodDefault for NGC container gets replicated #327

Closed NohaIhab closed 9 months ago

NohaIhab commented 9 months ago

What needs to get done

Define how the PodDefault (via config? via relation to resource dispatcher? charm action?) will be applied in the user namespaces

Why it needs to get done

this is one of the pieces outline the implementation for NGC container Notebook integration. It will be documented in the spec, tracked in issue https://github.com/canonical/notebook-operators/issues/326

NohaIhab commented 9 months ago

the PodDefault can be created via relation between jupyter-controller and resource dispatcher, it makes sense to utilize the existing resource-dispatcher charm. It will be done similarly to the relation between mlflow-operator and resource-dispatcher charms.

Charm implementation

resource-dispatcher charm

jupyter-controller charm

User experience

The user will need to:

syncronize-issues-to-jira[bot] commented 9 months ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5143.

This message was autogenerated

NohaIhab commented 9 months ago

the name of the integration in resource-dispatcher and jupyter-controller can be different (see juju docs), so we should make the integration name in jupyter-controller charm's side unique to NGC, while keeping the interface the same. It can be something like ngc-command. This is useful if we want to add other poddefaults for different containers.

kimwnasptd commented 9 months ago

Closing this since we discussed all the above with @NohaIhab and this is our plan for the implementation

NohaIhab commented 8 months ago

In the end after some discussions, we're going with a different implementation. A new charm ngc-integrator will own the poddefault and send it to resource dispatcher. This way, we are encapsulating the ngc configurations in an integrator charm. For more details, see the spec.