search

canonical / notebook-operators

Charmed Jupyter Notebooks
Apache License 2.0
5 stars 9 forks source link

`jupyter-ui` individual integration tests are flaky #359

Open DnPlas opened 4 months ago

DnPlas commented 4 months ago

Bug Description

The test_notebook_image_selector test case fails to assert the correct image values.

To Reproduce

Run the CI for this repository. I have only been able to see this failing in the track/1.8 Github branch, though.

Environment

The PR and merge CI.

Relevant Log Output

File "/home/runner/work/notebook-operators/notebook-operators/charms/jupyter-ui/tests/integration/test_charm.py", line 111, in test_notebook_image_selector
    assert actual_images == expected_images
AssertionError: assert ['kubeflownot...ython:v1.8.0'] == ['vscodeimage...vscodeimage2']
  At index 0 diff: 'kubeflownotebookswg/codeserver-python:v1.8.0' != 'vscodeimage1'
  Right contains one more item: 'vscodeimage2'
  Full diff:
  - ['vscodeimage1', 'vscodeimage2']
  + ['kubeflownotebookswg/codeserver-python:v1.8.0']

Additional Context

Some CI runs:

syncronize-issues-to-jira[bot] commented 4 months ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5595.

This message was autogenerated

ca-scribner commented 4 months ago

I saw this recently too, but haven't looked into it. Not sure if something has changed or ... ?

Its possible I broke something with the recent jupyter configuration PR too, but I'm not sure how

DnPlas commented 4 months ago

Your recent changes definitely removed this test case, but since ch:track/1.8 still has them, I don't think anything your did recently could've affected the branch. We need to investigate as the publish job is currently stuck because of that.