canonical / notebook-operators

Charmed Jupyter Notebooks

Apache License 2.0

5 stars 9 forks source link

Jupyter UI Sidecar rewrite #96

Closed i-chvets closed 1 year ago

i-chvets commented 1 year ago

Jupyter UI charm rewrite using sidecar pattern

Work items are tracked in Jira Branch: https://github.com/canonical/notebook-operators/tree/kf-701-gh96-feat-sidecar-rewrite

Design

Design is specified in corresponding spec. Main design points summary:

Use of sidecar pattern and Pebble layer.
Porting of managing K8S resources from Pod Spec to Pebble framework.
Use container interaction features from Charmed Operator Framework.
Relation to Istio is optional.
Pebble layer checks use the main UI page URL as HTTP endpoint.

Testing

Integration testing allows for verification of functionality.

Bundle testing is not available at this moment. Bug is filed: https://github.com/canonical/notebook-operators/issues/101

i-chvets commented 1 year ago

Filed bug https://github.com/canonical/notebook-operators/issues/99

i-chvets commented 1 year ago

Sidecar re-write is approved and merged. https://github.com/canonical/notebook-operators/pull/97

Two bugs filed:

99

101