search

canonical / observability-libs

A collection of charm libraries curated by the Observability team.
https://charmhub.io/observability-libs
Apache License 2.0
3 stars 8 forks source link

[cert handler] don't fail on vault.clear() failures #100

Closed PietroPasotti closed 2 months ago

PietroPasotti commented 2 months ago

Issue

Fixes #95

Solution

don't raise when calling Secret.remove_all_revisions fails with SecretNotFound.

Context

Unclear exactly what's causing this, as the _SecretVaultBackend already catches SecretNotFound and initializes a fresh secret in that case. It's odd that two lines later info-get on that fresh secret raises SecretNotFound again. Discussion with juju is ongoing to see whether we can find out what's going on.

Testing Instructions

Attempt to repro #95 and see if it's fixed