search

canonical / observability-libs

https://charmhub.io/observability-libs
Apache License 2.0
3 stars 8 forks source link

Custom evt #29

Closed beliaev-maksim closed 2 years ago

beliaev-maksim commented 2 years ago

Issue

user did have a possibility to change service definition during runtime.

Now we allow user to add custom events to be listened

beliaev-maksim commented 2 years ago

@dstathis is it fine that I bumped the version or should it be done right before publishing the lib?

dstathis commented 2 years ago

@dstathis is it fine that I bumped the version or should it be done right before publishing the lib?

Yes the libpatch should be bumped. That way you can release right after merging.

rbarry82 commented 2 years ago

LGTM in general (after the LIBPATCH bump). What's the use case?

beliaev-maksim commented 2 years ago

@rbarry82 I want to have an app and expose port as a part of the configuration file. It works brilliantly with prometheus scrape job targets but service patch is not applied. Thus, app is not available on service IP:PORT

and there was no way to reapply patch to a new configuration

I would assume there might be other use cases when user will need to fire a patching on a custom event