canonical / observability-libs

A collection of charm libraries curated by the Observability team.
https://charmhub.io/observability-libs
Apache License 2.0
3 stars 8 forks source link

fix: remove custom SIGTERM handler in the resource patcher #43

Closed jnsgruk closed 1 year ago

jnsgruk commented 1 year ago

Related to recent conversation about Juju transitioning through an error state when deploying charms that use the library.

It appears this was put in place around Oct 2022 when the original bug appeared in Juju. Now there has been a fix to juju which is included in 2.9.42 (latest/stable at time of writing), and this handler conflicts with that patch.

Removing this and updating the charms that depend on it should remedy the CI failures we've been seeing.