search

canonical / observability-libs

A collection of charm libraries curated by the Observability team.
https://charmhub.io/observability-libs
Apache License 2.0
3 stars 8 forks source link

codeql false positives #86

Closed PietroPasotti closed 2 months ago

PietroPasotti commented 4 months ago

Bug Description

Codeql gets triggered by some debug logging in cert_handler, resulting in CI failure and noctua being unable to merge automatic charm lib updates.

See for example in traefik: https://github.com/canonical/traefik-k8s-operator/pull/342

image

To Reproduce

https://github.com/canonical/traefik-k8s-operator/pull/342

Environment

n/a

Relevant log output

n/a

Additional context

We should investigate marking this lines as noqa or something like that, or renaming the variables before printing them so codeql won't get touchy about it.

ca-scribner commented 2 months ago

Closed as it'll soon be invalid when we move to Tiobe