canonical / observability-libs

A collection of charm libraries curated by the Observability team.
https://charmhub.io/observability-libs
Apache License 2.0
3 stars 8 forks source link

add check for private key existence #91

Closed michaeldmitry closed 4 months ago

michaeldmitry commented 4 months ago

Issue

by simply getting the private_key property, it now generates a new private key if it doesn't exist. Some charms access that property as a way of checking if its been generated or not (alertmanager), so it falsely generates a private key for the charm without even enabling tls on that charm.

Solution

added a new function to check for the existence of the key

michaeldmitry commented 4 months ago

agreed. closing PR for now/