search

canonical / observability

Apache License 2.0
7 stars 11 forks source link

Fix _rock-build-test workflow #126

Closed artivis closed 11 months ago

artivis commented 11 months ago

Fix #125

simskij commented 11 months ago

@artivis can you please amend your commit and sign it so that we can merge it?

artivis commented 11 months ago

@artivis can you please amend your commit and sign it so that we can merge it?

@simskij I'm not sure to understand, the commit is signed (Signed-off-by: artivis <jeremie.deray@canonical.com>). Is there something more to do?

simskij commented 11 months ago

@artivis can you please amend your commit and sign it so that we can merge it?

@simskij I'm not sure to understand, the commit is signed (Signed-off-by: artivis <jeremie.deray@canonical.com>). Is there something more to do?

I'll contact you directly , but basically, we need a gpg-sign (-S) as opposed to a Signed-off-by message (-s).

artivis commented 11 months ago

I'll contact you directly , but basically, we need a gpg-sign (-S) as opposed to a Signed-off-by message (-s).

I got that green tick on the commit ;)