Publish charms in PRs to temporary Charmhub branches

canonical / observability

Apache License 2.0

7 stars 11 forks source link

Publish charms in PRs to temporary Charmhub branches #169

Closed lucabello closed 4 months ago

lucabello commented 6 months ago

Whenever we run the charm PR workflows, right after we pack it and before we run the tests, we should upload it to a temporary Charmhub branch (e.g., latest/edge/pr-<number>).

This could also potentially be used by our integration tests (possibly as an added tox cli parameter) so that we don't need to pack the charm every time, and we can just pull it from Charmhub.

sed-i commented 6 months ago

References:

channel action for picking the target channel name. Note the latest/edge/pr-<pr number>.
Example usage for the channel action.

lucabello commented 4 months ago

The problem with this approach is that revision numbers would skyrocket quickly; unless we have a way to upload a charm without a revision number, I'd say we shouldn't do this.

All of our revision are currently also present in GitHub releases, and they show the changes that are brought in; it would be confusing to have numbers missing from that list.

Closing, but please re-open if I'm very wrong :D