search

canonical / oidc-gatekeeper-operator

Charmed OIDC Gatekeeper
Apache License 2.0
0 stars 7 forks source link

Remove the `public-url` configuration option #157

Open DnPlas opened 4 days ago

DnPlas commented 4 days ago

Context

The public-url configuration option is used in this charm for setting the OIDC_PROVIDER value, but #156 is proposing a different approach for setting it, so the config option is not required anymore.

This task requires the removal of the public-url configuration option as it has been considered misleading and should not be used. Please refer to https://github.com/canonical/bundle-kubeflow/issues/608 for more information.

What needs to get done

  1. Remove the public-url configuration option
  2. Remove all traces of it from the charm code
  3. Add/modify tests accordingly

Definition of Done

The option is not there anymore and the OIDC_PROVIDER value is set using relation data as suggested in #156

syncronize-issues-to-jira[bot] commented 4 days ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5969.

This message was autogenerated