search

canonical / open-documentation-academy

Learn open-source software documentation skills with Canonical
https://canonical.com/documentation
Apache License 2.0
48 stars 30 forks source link

Fixed issue #57 #58

Closed ade555 closed 1 month ago

ade555 commented 2 months ago

Documented how to troubleshoot the failed installation for WSL on Windows.

YanisaHS commented 2 months ago

Hey @ade555! Also wanted to let you know here - when you get around to addressing this PR, I think it'd be better if you moved this information into a different Troubleshooting file instead. The file path could be getting-started/troubleshoot.md.

This is so the set-up document can still be simplistic, and we could add additional topics to the troubleshooting guide later on if necessary. I'd also recommend you add a disclaimer to the existing WSL guide to link to this troubleshooting guide, and maybe also link to Microsoft's WSL docs.

Let me know if you have any questions on that. :smiley:

ade555 commented 2 months ago

Hey @ade555! Also wanted to let you know here - when you get around to addressing this PR, I think it'd be better if you moved this information into a different Troubleshooting file instead. The file path could be getting-started/troubleshoot.md.

This is so the set-up document can still be simplistic, and we could add additional topics to the troubleshooting guide later on if necessary. I'd also recommend you add a disclaimer to the existing WSL guide to link to this troubleshooting guide, and maybe also link to Microsoft's WSL docs.

Let me know if you have any questions on that. 😃

Thank you very much @YanisaHS. I'll make that change right now.

ade555 commented 2 months ago

Hi, @YanisaHS. I implemented your suggestions already. Please take a look and let me know what you think. Thank you!

ade555 commented 1 month ago

Hi @YanisaHS . Is there anything you'd like me to improve in the PR? Please let me know. Thank you very much.

YanisaHS commented 1 month ago

Hey @ade555! Sorry for the delay on this - our team just came back from a company-wide in-person event. I'll go through this PR (and your other one) either today or tomorrow :smiley:

ade555 commented 1 month ago

Hey @ade555! Sorry for the delay on this - our team just came back from a company-wide in-person event. I'll go through this PR (and your other one) either today or tomorrow 😃

@YanisaHS no worries at all! Thanks for letting me know. I hope the company event was fun and productive. I look forward to the PR reviews whenever you get a chance to review them.😊

ade555 commented 1 month ago

Hi, @YanisaHS. Thank you for your corrections on this PR. I just implemented them. Please take a look and give feedback. Thank you!

YanisaHS commented 1 month ago

Merged! You can see it live in the Open Documentation Academy repo here: https://github.com/canonical/open-documentation-academy/blob/main/getting-started/troubleshooting.md

Thanks again for the wonderful contribution!! :smiley: :partying_face: :tada:

ade555 commented 1 month ago

Thank you very much @YanisaHS! It was nice collaborating with you on this one.