search

canonical / open-documentation-academy

Learn open-source software documentation skills with Canonical
https://canonical.com/documentation
Apache License 2.0
48 stars 28 forks source link

Fix for issue #49 #68

Closed ade555 closed 1 month ago

ade555 commented 1 month ago

Fix issue #49

Hi, @YanisaHS please check out my PR and let me know what you think. I'm happy to make necessary corrections.

YanisaHS commented 1 month ago

Hey @ade555! It looks like you might have branched off of your other WSL branch to make these changes. No problem :smiley: but can you remove the WSL-related files from this PR so it's only the Landscape "distribution" term stuff?

It's not blocking my review, but I just want to get that cleaned up to not conflict with your other PR. I'll tag you here and on the other PR when I'm ready for you to address any suggestions. Thanks!

ade555 commented 1 month ago

Hey @ade555! It looks like you might have branched off of your other WSL branch to make these changes. No problem 😃 but can you remove the WSL-related files from this PR so it's only the Landscape "distribution" term stuff?

It's not blocking my review, but I just want to get that cleaned up to not conflict with your other PR. I'll tag you here and on the other PR when I'm ready for you to address any suggestions. Thanks!

Hi, @YanisaHS . Thanks for pointing it out. I must have overlooked it earlier. I have removed the WSL-related files already. I apologize for the oversight.

ade555 commented 1 month ago

Hi, @YanisaHS. Thank you very much for your feedback. I learned something important from the corrections you made. I'm also glad you found my contribution a bit impressive.

I already made changes to reflect the corrections you made. Kindly review it once more. Thank you!

YanisaHS commented 1 month ago

@ade555 Thanks so much for your wonderful contribution!! :rocket: :partying_face: :balloon: You can see it live here: https://ubuntu.com/landscape/docs/explanation-distribution (yay!!)

Hope to work with you again soon! And if you have any feedback on this PR process or contributing to Canonical's Open Documentation Academy, please feel free to leave it as a comment here.

ade555 commented 1 month ago

Yay! It's really nice to see this go live. I really enjoyed collaborating with you on this PR and I will definitely like to work with you again. Your corrections helped me improve.

@YanisaHS