canonical / openldap-k8s-operator

openldap-k8s-operator - charm repository.
GNU General Public License v3.0
0 stars 3 forks source link

chore: remove outdated metaclass #15

Open tonyandrewmeyer opened 8 months ago

tonyandrewmeyer commented 8 months ago

The _ObjectABCMeta metaclass is not required, so can be removed.

With this change, the unit tests pass with the current version of ops. There are no functional changes in this PR.

For what it's worth, I suspect that much of what's in src/leadership.py can probably be removed now. Feel free to reach out to @canonical/charm-tech if you need assistance with any ops modernisation!

tonyandrewmeyer commented 8 months ago

The failure is in the integration tests bootstrapping the controller, before the charm is deployed, so should not be related to this change. Let me know if I'm wrong about that and need to address something here.