canonical / opensearch-dashboards-operator

Opensearch Dashboards Juju Charm
Apache License 2.0
0 stars 1 forks source link

[DESIGN] IP Address change should be checked based on the rendered opensearch_dashboards.yml #27

Open Mehdi-Bendriss opened 5 months ago

Mehdi-Bendriss commented 5 months ago

Context for issue: https://github.com/canonical/opensearch-dashboards-operator/pull/22#discussion_r1587272284

github-actions[bot] commented 5 months ago

https://warthogs.atlassian.net/browse/DPE-4293

juditnovak commented 5 months ago

Is there a specific reason for this request? I mean what is the problem, or currently broken/mssing feature that we are trying to solve with this?

juditnovak commented 5 months ago

Part of the reason why I'm asking is the following: the Dasboard is missing core features and core checks right now, like

While perfectly responds to all expected functionality and stress test.

juditnovak commented 5 months ago

...also please note that the requested check is redundant thus not missing.

On each reconcile() handler exectu (that's executed on all charm-level base events):

juditnovak commented 5 months ago

My most important question here is: what kind of action do we want to take based on the IP in the config?

The reason why I'm asking is because the IP change in the config is rather an "end result" of a process, than the cause/origin.

What I mean is: typically under certain circumstances we decide to change the IP in the config.

What I would like to understand here is why would we want to know the status of the config file, i.e. what kind of actions may (or may not) be done based on the actual state of the config file? In other words: assuming we implement this check -- what would we do with the information that comes out of it?