canonical / opensearch-operator

OpenSearch operator
Apache License 2.0
11 stars 6 forks source link

Remove "non-charmed" user deletion at `update-status` and `client-broken` #331

Closed phvalguima closed 1 week ago

phvalguima commented 3 months ago

Currently, we have OpenSearchUserManager.remove_users_and_roles, which removes users and roles that are not linked to system users or existing relations. The removal happens here.

This method is called in two different places: update status and client relation broken events. Now, removing the relation user and role makes sense, but we should only remove that user / role, not a generic clean-up. We should also remove the call from update_status.

github-actions[bot] commented 3 months ago

https://warthogs.atlassian.net/browse/DPE-4682

Mehdi-Bendriss commented 3 months ago

That's a good one. We should filter out of the removal / cleanup routine users not created through the charm's client relations.

juditnovak commented 3 weeks ago

Shortly: the request is to support manually created users.