search

canonical / openstack-exporter-operator

The openstack-exporter-operator is a machine charm for openstack-exporter.
Apache License 2.0
1 stars 7 forks source link

Review Charm for Listing #100

Open jneo8 opened 2 months ago

jneo8 commented 2 months ago

PR for reviewing charm code as defined in: https://discourse.charmhub.io/t/reviewing-charms/11698.

jdkandersson commented 2 months ago

Could you please leave a note here on anything that you have addressed already? Just to make it easier for me to track what still would need to be resolved please

jdkandersson commented 2 months ago

Given that there have been quite a few changes, could you update this PR with the latest code? Then I can take a look at the changes and also review the tests 🙂

jneo8 commented 1 month ago

Given that there have been quite a few changes, could you update this PR with the latest code? Then I can take a look at the changes and also review the tests 🙂

Hi @jdkandersson , sorry for the delay. I merge the upstream/main to this review branch.