search

canonical / openstack-exporter-operator

The openstack-exporter-operator is a machine charm for openstack-exporter.
Apache License 2.0
1 stars 6 forks source link

Support `SnapService` to manage all services within the same snap. #14

Closed chanchiwai-ray closed 5 months ago

chanchiwai-ray commented 5 months ago

Remove service_name attribute and argument from SnapService, since snap's start and stop operation supports all services if the service name is not provided. Also, update the SnapService.is_active() to accept a service name args, this will allow for checking the status of a particular service within the snap.

Closes: #10

chanchiwai-ray commented 5 months ago

Wouldn't it be weird that you need to start or stop every service?

Normally, the services within the snap should work together, so start or stop all services isn't that bad. Also, in our case, it does not matter.

samuelallan72 commented 5 months ago

Thanks, this looks good, but merge conflicts need resolving first. :)

chanchiwai-ray commented 5 months ago

Rebased onto main

samuelallan72 commented 5 months ago

@chanchiwai-ray ah sorry, there is now a merge conflict :sweat_smile:

chanchiwai-ray commented 5 months ago

tested again, the new is_active method works as expected

chanchiwai-ray commented 5 months ago

rebased