search

canonical / openstack-exporter-operator

The openstack-exporter-operator is a machine charm for openstack-exporter.
Apache License 2.0
1 stars 6 forks source link

Add lint and unit test workflow. #16

Closed chanchiwai-ray closed 7 months ago

chanchiwai-ray commented 7 months ago

Add lint and unit test workflow when PR is created on the main branch.

See example runs of the workflow from my fork.

chanchiwai-ray commented 7 months ago

Also, while we're here, can we remove format and unit from the default env list run when a bare tox is run? I think it's probably enough that a bare tox just runs the linters.

Sure, thanks for bringing this up. I also feel that the tox target introduce in charmcraft init a bit inconvenient to use. If you already have an idea, can you open a PR? But I will prefer keeping keeping unit test in default tox target since it's cheap to run (if unit tests are implemented correctly); it's okay to me merging static and lint into code-quailty (probably a better and shorter name)

chanchiwai-ray commented 7 months ago

Added some dependency after rebasing onto main