search

canonical / openstack-exporter-operator

The openstack-exporter-operator is a machine charm for openstack-exporter.
https://charmhub.io/openstack-exporter
Apache License 2.0
1 stars 6 forks source link

Add new script to sync dashboards #39

Closed samuelallan72 closed 3 months ago

samuelallan72 commented 3 months ago

With a flag to check if dashboards are updated (so make check-dashboard-updates still works).

Also run the script to sync the dashboards.

chanchiwai-ray commented 3 months ago

Spotted small issue: running the script in the scripts directory will not work properly. (see previous implementation) because of the relative path

samuelallan72 commented 3 months ago

Spotted small issue: running the script in the script directory will not work properly

Yes, this is not supported. Usually convention for scripts is that they are run from the root of the repository. We also have it documented as running the make targets from the root of the repo.

jneo8 commented 3 months ago

I want to bring up different solution here. Can't we just use wget and diff commands? I feel it will be more easier than using python.

Since it's a simple script and the scrips size will be similar. It's ok to go with python.