search

canonical / openstack-exporter-operator

The openstack-exporter-operator is a machine charm for openstack-exporter.
Apache License 2.0
1 stars 6 forks source link

Relate to keystone to get credentials for exporter #4

Closed samuelallan72 closed 5 months ago

samuelallan72 commented 5 months ago

Save these credentials to a clouds.yaml file, so they can be used by openstack-exporter.

If keystone in your test environment uses https, you may need to manually set the ssl_ca config.

internal ticket: BSENG-2172

samuelallan72 commented 5 months ago

@chanchiwai-ray thanks for your review! I responded to your comments; please see latest commits. :)

samuelallan72 commented 5 months ago

Thanks @jneo8 and @chanchiwai-ray , I responded to your comments.

samuelallan72 commented 5 months ago

Can we make the non-event function without the _ prefix? It just looks nicer to me, and make me easier to visually distinguish the event callbacks and normal functions

So ideally all the other methods should have the _ prefix too, as this is used as a convention to show that they are internal methods and shouldn't be called from outside the class.

chanchiwai-ray commented 5 months ago

Can we make the non-event function without the _ prefix? It just looks nicer to me, and make me easier to visually distinguish the event callbacks and normal functions

So ideally all the other methods should have the _ prefix too, as this is used as a convention to show that they are internal methods and shouldn't be called from outside the class.

Yes, I understand that, so it's optional