canonical / openstack-exporter-operator

The openstack-exporter-operator is a machine charm for openstack-exporter.
Apache License 2.0
1 stars 7 forks source link

Don't enter blocked status if grafana-agent not related #45

Closed samuelallan72 closed 2 weeks ago

samuelallan72 commented 7 months ago

Currently if grafana-agent is not related the charm will be in blocked status. Possibly this could be confusing. We could consider leaving in active state (perhaps with a message in the status about relating to grafana-agent for dashboards and prometheus scraping).

To discuss.

Pros of staying blocked when no grafana-agent

Pros of changing to active when no grafana-agent

aieri commented 3 weeks ago

I think setting blocked is good because it makes the charm self-validating, avoiding the need to write rules for juju-lint or juju-doctor

samuelallan72 commented 2 weeks ago

That's a fair comment. If it makes it easier for operations, then let's keep it as is. :+1:

aieri commented 2 weeks ago

closing as won't do as we actually like the current behavior :)