search

canonical / openstack-exporter-operator

The openstack-exporter-operator is a machine charm for openstack-exporter.
https://charmhub.io/openstack-exporter
Apache License 2.0
1 stars 6 forks source link

`Free (resources) per host` is too easy to turn into red #47

Closed nobuto-m closed 2 months ago

nobuto-m commented 3 months ago

It looks like there are some logic of changing the color of the panel based on the data. For example with the Free vCPUs per host panel, it will turn into red when free vCPU per host is less than 100.

It's a little bit too aggressive to mark it as red (critical) to me. It might be better to use percentages instead of absolute values.

https://github.com/canonical/openstack-exporter-operator/blob/882043f084a4b9164e944a964e366e12cd551e22/src/grafana_dashboards/overview-openstack-exporter-dashboard.json#L1572-L1655

samuelallan72 commented 3 months ago

@nobuto-m agreed, this sounds good. Would you have percentages in mind that should flag red? These panels also currently have two levels of flagging - red (for danger I guess) and yellow (warning). I'm thinking something like 5% remaining would be red, 15% yellow?

samuelallan72 commented 3 months ago

Note that I'm not sure personally how to implement percentage-based colouring here, since percentage in the table is between min and max observed values (not the actual total resources available). :thinking:

Perhaps it's best to drop the colouring altogether in this case, and leave it up to alerts for cases where resources are getting low.

samuelallan72 commented 3 months ago

Addressing in openstack/sunbeam-charms/+/917111. I'm addressing by removing the thresholds and conditional colouring from these altogether. This should avoid any confusion with arbitrary reds and oranges.