Set cache default option to True

canonical / openstack-exporter-operator

The openstack-exporter-operator is a machine charm for openstack-exporter.

Apache License 2.0

1 stars 6 forks source link

Set cache default option to True #76

Closed gabrielcocenza closed 2 months ago

gabrielcocenza commented 2 months ago

Having the cache option set to True will make the exporter work out of the box. Right now if not changed, the time to scrape is bigger than 10 seconds and it fails.

samuelallan72 commented 2 months ago

Once merged, please be sure to update the charmhub docs ( https://charmhub.io/openstack-exporter ):

the "enable the cache" page may need to be changed to "disable the cache" or "manage the cache feature" or something similar, since it's enabled by default now.
the metrics caching also will need updating.
until it's on latest/stable, we probably should have a note about this changing in revision XX.

gabrielcocenza commented 2 months ago

@samuelallan72 I've created a new issue #78 to track that.

Should we change the documentation after reaching the stable release?

gabrielcocenza commented 2 months ago

@jneo8

question(non-blocking): I kind of lose why we want to enable cache as default, the upstream exporter default is false.

The motivation behind it it's because the scrape was failing, at least on serverstack (I didn't try on partner cloud or other environment that is more realistic with production) and it's not a good user experience to try to figure out why it's not working. Having it set to True we kind guarantee that will start working out of the box

jneo8 commented 2 months ago

The motivation behind it it's because the scrape was failing, at least on serverstack (I didn't try on partner cloud or other environment that is more realistic with production) and it's not a good user experience to try to figure out why it's not working. Having it set to True we kind guarantee that will start working out of the box

My concern is about the meaning of the metrics become a little bit different after you open the cache. This is also a major concern from others so we decide to not enable it as default and provide the same experience as upstream.

I am ok to enable cache as default, if there are more concern from others then we can discuss if we want to set it back.