canonical / openstack-exporter-operator

The openstack-exporter-operator is a machine charm for openstack-exporter.
Apache License 2.0
1 stars 7 forks source link

Project is not setting 100% coverage #92

Open gabrielcocenza opened 3 months ago

gabrielcocenza commented 3 months ago

This project doesn't set the tool coverage to 100% which can decrease the code quality.

Right now the project is at 66% coverage

unit run-test: commands[1] | coverage report
Name             Stmts   Miss  Cover   Missing
----------------------------------------------
src/charm.py        99     35    65%   72, 97-124, 131-136, 151-155, 175-177, 199-201, 213, 217-237
src/service.py      69     22    68%   23, 36-38, 42, 47-51, 121-131, 139-143
----------------------------------------------
TOTAL              168     57    66%
Coverage failure: total of 66 is less than fail-under=100

We need to reach to 100% and then change the configuration on pyproject.toml. Would also be nice to have a standard pyproject file into soleng automation to force new projects