canonical / operator

Pure Python framework for writing Juju charms
Apache License 2.0
247 stars 119 forks source link

chore: update charm pins #1390

Closed benhoyt closed 1 month ago

benhoyt commented 1 month ago

This is an automated PR to update pins of the external repositories that the operator framework is tested against

tonyandrewmeyer commented 1 month ago

With this:

diff --git a/requirements.txt b/requirements.txt
index 29ba811..ea137a2 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,7 +1,8 @@
 cosl
 cryptography
 jsonschema
-ops
+#ops
+git+https://github.com/canonical/operator
 pyaml
 requests
 lightkube >= 0.11

I get this locally, with 1bd9e7fd96a9f5a91443e5932667c58a92c1ce5e:

============================ 24 failed, 114 passed, 4 warnings in 3.94s ============================
tonyandrewmeyer commented 1 month ago

(I do love the way that this automation drops the disabled comment when everything is fine again).

Ah, actually this is the problem when I look more closely. It's not removing the disabled comment, it's removing all the comments which also removes some of the repos to check against, and that's why things are passing.

dimaqq commented 1 month ago

(I do love the way that this automation drops the disabled comment when everything is fine again).

Ah, actually this is the problem when I look more closely. It's not removing the disabled comment, it's removing all the comments which also removes some of the repos to check against, and that's why things are passing.

Ahhh!!! maybe a solution is to have separate comment nodes? I tried to be round-trip safe with yaml, but there's only so much I can do.