errors = []
# do something
return Results(errors, [])
I think the latter is less readable since one needs to click into the definition of Results to know what the second parameter is and why it's an empty list. To improve consistency of the code, we want to keep the same style.
There are inconsistent code in consistency_checker (the irony is in the file name 🤣):
Some places do:
Other places do:
I think the latter is less readable since one needs to click into the definition of
Results
to know what the second parameter is and why it's an empty list. To improve consistency of the code, we want to keep the same style.