search

canonical / ops-scenario

State-transition testing SDK for Operator Framework Juju charms.
Apache License 2.0
10 stars 7 forks source link

fixed config mutation in state #145

Closed PietroPasotti closed 2 months ago

PietroPasotti commented 2 months ago

Fixes #144

config_get had a subtle bug causing the state_in.config to be mutated when called. Fixed by copying the input config.

PietroPasotti commented 2 months ago

@tonyandrewmeyer do we cherry pick this in the 7.0 branch, or do you want to do a larger final rebase before releasing?

tonyandrewmeyer commented 2 months ago

@tonyandrewmeyer do we cherry pick this in the 7.0 branch, or do you want to do a larger final rebase before releasing?

Yeah, good question. I have ignored it so far, but really ought to get the main changes into 7. Do you have any preference?

PietroPasotti commented 2 months ago

not really, I guess it's easier to do a rebase to avoid missing anything?

tonyandrewmeyer commented 2 months ago

not really, I guess it's easier to do a rebase to avoid missing anything?

Probably yes. I wish I had paid more attention earlier and realised that I was not squashing when I merged into 7.0 :disappointed:.

I'll work on cleaning this up.