search

canonical / ops-scenario

State-transition testing SDK for Operator Framework Juju charms.
Apache License 2.0
10 stars 7 forks source link

add jujucontext support #182

Closed PietroPasotti closed 2 weeks ago

PietroPasotti commented 2 weeks ago

Support for ops 2.16.0

tonyandrewmeyer commented 2 weeks ago

This has a bunch of conflicts with the changes from #178, mostly because it's trying to do the same thing.

The static checks do fail with ops 2.16, because there's code to handle both 2.15 and 2.16 and the checker doesn't understand that. I should have added # type: ignores there I guess. We could do that to get the checks passing.

Would you rather we require 2.16 and swap out #178 for this simpler change? I figured we would eventually do that in #179, but that it was maybe better to allow people to have older ops for a bit. But happy to do that if you prefer.

PietroPasotti commented 2 weeks ago

I may have misread the issue in jhack. perhaps this change is not necessary and all I need is simultaneously bump scenario and ops

dimaqq commented 2 weeks ago

Yes, bump both at the same time.