search

canonical / packer-maas

Packer templates to create MAAS deployable images
Other
279 stars 167 forks source link

Incorrect product key variable used in makefile for comaparison #255

Closed 10Peppermill closed 2 days ago

10Peppermill commented 1 month ago

On line 42 of packer-maas/windows/makefile a comparison between the variable $(PKEY1) and nothing is used to determine if the autounattended needs to be modified to include a product key. Since the comparison is of the undefined variable PKEY1 the autounattended file never gets updated with a product key. Replacing PKEY1 with PKEY fixes the issue.

https://github.com/canonical/packer-maas/blob/87b80962783979958640c88654d8b7615bc0aa6a/windows/Makefile#L42

TLDR: someone fatfingerd a 1 onto the end of a variable name 😆

alexsander-souza commented 2 weeks ago

Hi @10Peppermill, thank you for looking into this.