canonical / pc-gadget

The gadget snap for Personal Computers using 64bit Intel or AMD processors
GNU General Public License v3.0
31 stars 73 forks source link

grub.cfg-normal: set snapd_recovery_mode= run in run mode #28

Closed mvo5 closed 4 years ago

mvo5 commented 4 years ago

The grub.cfg-normal will run from the ubuntu-boot partition. In order for "the-tool" to run and call snap-bootstrap to setup the right mount in run-mode this kernel commandline has to be set.

The-tool has a "ConditionKernelCommandLine=snapd_recovery_mode" so it only runs with that.

There is a bunch more cleanup that should be done in this file but to keep churn minimal it just does this one change.

xnox commented 4 years ago

I'd rather drop the restriction on the-tool. Originally added it, because the-tool / snap-bootstrap at the time could not handle the run mode, but it can now.

xnox commented 4 years ago

actually snap-bootstrap itself needs it.