canonical / pebble

Take control of your internal daemons!
https://canonical-pebble.readthedocs-hosted.com/
GNU General Public License v3.0
143 stars 54 forks source link

fix(snap): drive the snap release workflow to avoid skipping tagged versions #316

Closed cjdcordeiro closed 10 months ago

cjdcordeiro commented 10 months ago

Fixes #300.

This PR addresses the issue described in #300. It includes the following changes:

Before merging

  1. disconnect this repository from the Pebble snap "Builds" in the snap store
  2. add the following new secrets to the repo (thus why the CI is failing for this PR):
    • LP_CREDENTIALS (new and already shared with the team)
    • PEBBLE_DEV_MAILING_LIST (already shared with the team in the past)

This has been tested in: https://github.com/cjdcordeiro/pebble/actions/runs/6505676433 and https://github.com/cjdcordeiro/pebble/actions/runs/6505679630

jnsgruk commented 10 months ago

I've added the credentials to the repo, disconnected from the snapcraft.io build service - I've just retriggered the CI to ensure that it passes before merging.

cjdcordeiro commented 10 months ago

It seems like the job is not picking up on the LP_CREDENTIALS secret

  echo '' > ${lp_creds_path}/credentials
jnsgruk commented 10 months ago

No I think that's just because it doesn't include sensitive values in the log output :) I'm not sure what happened here, there is definitely a secret named LP_CREDENTIALS in place now

cjdcordeiro commented 10 months ago

When it's a secret GH will printout *** in lieu of the variable. Example -> https://github.com/cjdcordeiro/pebble/actions/runs/6505676433/job/17669768265

In this case, it didn't read anything. Can you check the repository's workflow permissions?

jnsgruk commented 10 months ago

Closing this PR in favour of #322