canonical / pebble

Take control of your internal daemons!
https://canonical-pebble.readthedocs-hosted.com/
GNU General Public License v3.0
143 stars 54 forks source link

Do client-side validation of IDs we're using in URL paths #318

Closed benhoyt closed 5 months ago

benhoyt commented 10 months ago

Per this code review comment, let's avoid directly inserting arbitrary strings from the caller into URL paths to send to the server -- better to lightly validate to avoid potential security issues.

I did this for Client.Notice in that PR, but we should also do it in client/changes.go and any other places in the client that does this.