canonical / pebble

Take control of your internal daemons!
https://canonical-pebble.readthedocs-hosted.com/
GNU General Public License v3.0
143 stars 54 forks source link

ci(snap): cope with concurrent builds #341

Closed cjdcordeiro closed 8 months ago

cjdcordeiro commented 8 months ago

At the moment, the Pebble release process involves a series of 3 commits in a very short amount of time. GitHub's concurrency flag is being used to cope with this, but it is unable to wait for pending workflow runs (see the bug), which raises the risk of a Release workflow cancelling the previous commit workflow, where the snap is being built, if the run is pending, waiting for a GH runner.

This commit forces the snap build to happen on releases also.


This change has been tested in https://github.com/cjdcordeiro/pebble/actions/runs/7221185730 (for regular pushes to master) and https://github.com/cjdcordeiro/pebble/actions/runs/7220657549 (for releases)