search

canonical / pebble

Pebble is a lightweight Linux service manager with layered configuration and an HTTP API.
https://canonical-pebble.readthedocs-hosted.com/
GNU General Public License v3.0
146 stars 54 forks source link

fix(client): WebSockets dialer with client BaseURL set #389

Closed thp-canonical closed 6 months ago

thp-canonical commented 6 months ago

Add a custom TCP dialer to allow WebSockets to work with remote TCP connections for clients that have BaseURL set.

thp-canonical commented 6 months ago

@benhoyt I've opened #393 as a potentially cleaner fix, but I still have to test if #393 has the same effect as this PR here (otherwise I'd have just update this PR with the #393 contents instead of having multiple PRs open that do the same thing - sorry for the noise).

I'll report back and close this PR if #393 indeed fixes the websocket (pebble exec) issue.

thp-canonical commented 6 months ago

Superseded by #393.