search

canonical / pebble

Take control of your internal daemons!
GNU General Public License v3.0
137 stars 52 forks source link

fix(taskrunner): consistent, nicer formatting for task failed log #391

Closed benhoyt closed 3 months ago

benhoyt commented 4 months ago

This changes this log:

2024-03-21T06:37:37.224Z [pebble] [change 32 "Start service \"svc1\"" task] failed: cannot start service: exited quickly with code 1

To this, which is more consistent with the formatting of the other Pebble logs:

2024-03-21T06:43:09.559Z [pebble] Change 33 task (Start service "svc1") failed: cannot start service: exited quickly with code 1

This log was introduced in this commit: https://github.com/canonical/pebble/commit/e494ff2eed86799ce5756ae02f9442b890c3472f#diff-e8b7c8da8654dde95838cfa0cc4b497cdd32050ea3a1bf0640e6404303aef0d6R294 which was pulled across from snapd, which originally added it here: https://github.com/snapcore/snapd/commit/8b2a5a8b9b62408e4d549fde3d231f2775dce3b9

benhoyt commented 3 months ago

Thanks @olivercalder -- merging.