canonical / pgbouncer-k8s-operator

A charmed operator for running PGbouncer on Kubernetes.
https://charmhub.io/pgbouncer-k8s
Apache License 2.0
7 stars 5 forks source link

[DPE-4236] Nodeport upgrade #342

Closed dragomirp closed 1 month ago

dragomirp commented 1 month ago

The service gets overridden during upgrade and the node port configuration gets lost.

Changed to create a separate service for nodeport.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 84.61538% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.66%. Comparing base (92a01e7) to head (dec0fa2).

Files Patch % Lines
src/charm.py 93.10% 2 Missing :warning:
src/relations/backend_database.py 50.00% 0 Missing and 2 partials :warning:
src/upgrade.py 66.66% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #342 +/- ## ========================================== + Coverage 71.04% 71.66% +0.62% ========================================== Files 8 8 Lines 1250 1274 +24 Branches 236 242 +6 ========================================== + Hits 888 913 +25 Misses 275 275 + Partials 87 86 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.