search

canonical / pgbouncer-operator

A charmed operator for running PgBouncer on virtual machines.
https://charmhub.io/pgbouncer?channel=1/stable
Apache License 2.0
4 stars 4 forks source link

Stop patching the private ops.testing._TestingModelBackend class #363

Closed tonyandrewmeyer closed 1 month ago

tonyandrewmeyer commented 1 month ago

Steps to reproduce

  1. grep _TestingModelBackEnd

Expected behavior

No results

Actual behavior

Results.

Versions

Operating system: N/A

Juju CLI: N/A

Juju agent: N/A

postgresql charm revision: N/A pgbouncer charm revision: N/A

LXD: N/A

Log output

Juju debug log: N/A

Additional context

As _TestingModelBackend is a private class, no guarantees are made about compatibility, and the tests relying on patching this class will break in an upcoming ops release.

The patching is actually no longer required with recent versions of ops, so mostly the patching can just be removed, with the occasional add_network call potentially required.

You can use these PRs as examples if needed:

If any assistance is required, please reach out to @canonical/charm-tech and we'll be happy to help!

syncronize-issues-to-jira[bot] commented 1 month ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/DPE-5445.

This message was autogenerated

dragomirp commented 1 month ago

Should be handled by https://github.com/canonical/pgbouncer-operator/pull/367