search

canonical / pi-gadget

Universal pi (pi2,pi3,pi4,cm3,cm4 and future) gadget snap for Ubuntu Core and classic systems.
37 stars 62 forks source link

Pull in uboot v2019.04 for pi3. #14

Closed sil2100 closed 5 years ago

sil2100 commented 5 years ago

This is mirroring what has been merged in pi3-gadget for the core16 gadgets.

sil2100 commented 5 years ago

Ok, so since this patch modification actually drops some pieces from the u-boot pi header config, I did a few checks to see if everything's still fine. First of all I grepped the new u-boot source for any usages of the now-dropped definitions - my search gave no results. This would confirm these were not needed since long and were just added previously for no reason (probably just to stay overly-consistent). I also built a snap out of it, then built a pi3 18 image with the custom gadget snap and did a boot test, comparing it with a previous image. The image booted fine with no visible regressions.

With all this, let me merge it in. We'll anyway have to request some additional testing from CE as the same change landed for the 16 pi3 gadget.