Add guidance on interacting with UI elements

canonical / praecepta

Creative Commons Attribution Share Alike 4.0 International

12 stars 18 forks source link

Add guidance on interacting with UI elements #13

Closed YanisaHS closed 7 months ago

YanisaHS commented 7 months ago

What I did:

Added a section on Interacting with UI elements to the Style Guide
Added images for this new section
Added the build file to .gitignore

YanisaHS commented 7 months ago

@evilnick I've added you as a reviewer. Feel free to add a second reviewer - I'm not sure how we typically review PRs like this

evilnick commented 7 months ago

Thanks for this, it looks good at first glance, I will go through it properly in a bit. One thing I am annoyingly going to ask though is that the images go in the asset server not in this repo

YanisaHS commented 7 months ago

@evilnick I'm done addressing your changes. The only additional thing I changed is that one of the icon use cases was changed because I couldn't get one image to upload to the asset manager. (the star one is new)

YanisaHS commented 7 months ago

@tmihoc @degville I've added you both as reviewers as well since this change affects the whole team

YanisaHS commented 7 months ago

@tmihoc @degville Reminder to review this :smiley:

YanisaHS commented 7 months ago

@tmihoc Thanks for your detailed review!! :heart: I looked through your changes and am planning to have those changes on hold for now. I will address them in a later pulse/PR since they're not critical to the main content - this story has been going on for a long time so I'd rather just get the major content out there and I can make your refinements later.