Rule 13 (spell out numbers below 10) should ignore numbers that contain punctuation

userMaximilian commented 2 days ago

Hello!

Rule 13 currently generates warnings for single digits that are preceded and/or followed by punctuation, such as in:

comma separated numbers (like the '5' in '5,000');
numbers preceded with a currency sign (like the '3' in '£3.50');
numbers with a decimal place (like the '5' in '5.15'); and
version numbers (like some/all of the digits in '6.6.0' or the final digit in '3-1-2')

The warnings generated also sometimes differ if the number is at the start and/or end of a line. For example, Vale warns on each digit in the line "Test 6.6.0\n", but only the last two digits in the line "6.6.0\n".

I'm happy to help with preparing a PR or testing as needed, if that would be helpful.

SecondSkoll commented 2 days ago

You are quite correct. This should be solvable with a negative lookbehind and an alteration to the existing negative lookahead. It should be a relatively easy fix. Thanks!

SecondSkoll commented 1 day ago

Resolved with #53

canonical / praecepta

Rule 13 (spell out numbers below 10) should ignore numbers that contain punctuation #51