canonical / prometheus-hardware-exporter

Prometheus Hardware Exporter is an exporter for Hardware Observer
GNU General Public License v3.0
10 stars 9 forks source link

handle different storage controller responses #58

Closed sdemircan closed 7 months ago

sdemircan commented 11 months ago

While checking storage controller data in get_storage_controller_data function API response varies between different ILO versions and different vendors(ie. Inspur).

chanchiwai-ray commented 11 months ago

Can you provide the iLO version and the vendor (Inspur)'s official documentation for Redfish ?

sdemircan commented 11 months ago

Can you provide the iLO version and the vendor (Inspur)'s official documentation for Redfish ?

ILO version is 2.99. It returns storage controller information with Controllers key.

Inspur servers have a different problem. When sending request to storage_root_uri slash suffix that appended to URI makes API call invalid. I will attach Inspur's official documentation for Redfish when I find it.

@rgildein I have made changes based on your reviews. I will push them when I complete unit tests.

chanchiwai-ray commented 7 months ago

Thanks @sdemircan for the work, this has been superseded by #71. Feel free to report further issues if you find any !