collector: get sensible machine hostname

canonical / prometheus-juju-exporter

GNU General Public License v3.0

2 stars 8 forks source link

collector: get sensible machine hostname #29

Closed mert-kirpici closed 1 year ago

mert-kirpici commented 1 year ago

The "hostname" field in the machine status information coming from libjuju is not very stable for controllers with older versions starting from 2.8.9. We are trying to fall back to using "instance-id" field in the case hostname is unavailable or none.

Works-on: #24, #25

mert-kirpici commented 1 year ago

Hi folks, could you take a look at this change for a sanity check before I go ahead and test on some old juju versions?

mert-kirpici commented 1 year ago

The latest changes are manually tested against juju controller versions:

2.9.38
2.8.1
2.7.6
2.6.4