Closed jnsgruk closed 2 years ago
Libraries are not up to date with their remote counterparts. If this was
not intentional, run charmcraft fetch-libs
and commit the updated libs
to your PR branch.
Debating in my mind if a better plan here is to fork the lib?
Iiuc, the working assumptions so far were:
multiple apps using the same interface structure
Would you mind clarifying the context?
Yeh, I'm gonna rethink this.
Issue
The Prometheus
scrape_targets
config structure is used by quite a few different applications. The lib in its current form means that we'll always need to use theprometheus_scrape
interface name for this library to work, which may introduce unforseen bugs if there are multiple apps using the same interface structure, and could get wired up wrong at runtime.Solution
This is submitted for discussion - and would enable the ability for charm developers to use the library for a custom relation name. The changes only cover
MetricsEndpointProvider
andMetricsEndpointConsumer
at this point. I don't forsee theMetricsEndpointAggregator
being universally useful in the same way.