search

canonical / prometheus-k8s-operator

https://charmhub.io/prometheus-k8s
Apache License 2.0
21 stars 35 forks source link

If a push fails, prometheus may never be reload even though config changed (theoretical edge-case) #369

Open sed-i opened 2 years ago

sed-i commented 2 years ago

If some files were pushed but others failed, when _configure re-enters then should_reload may be false without prometheus ever reloading.

https://github.com/canonical/prometheus-k8s-operator/blob/b4c0fd631a8bfbeb7d22b9b6f157f8f25cefc6f6/src/charm.py#L292-L304

PietroPasotti commented 1 year ago

we should probably let the error bubble up in this case, assuming the caller checked container.can_connect before this happens. Error state seems appropriate because this really shouldn't happen.