Stop using remote storage - Githubissues

canonical / prometheus-k8s-operator

https://charmhub.io/prometheus-k8s

Apache License 2.0

21 stars 35 forks source link

Stop using remote storage #431

Closed sed-i closed 1 year ago

sed-i commented 1 year ago

Issue

Incorrectly assumed that the charm uses controller storage, when in fact it was using local storage (see https://github.com/canonical/operator/issues/880)
Config and alerts hash was originally intended to be written to controller storage, which is wrong because files wouldnt be written to container after an upgrade (because hash(relation-data) would match the hash in stored state).

Solution

Do not use remote storage (remove _stored).
Save hashes to container filesystem.

Fixes #399 Fixes #414 Fixes #418

Context

NTA.

Testing Instructions

See new tests.
In a prom --(self monitoring)-- prom constellation, refresh one of the proms and make sure the config file, alert rules and scrape targets are as they were before the refresh (covered in itest).

Release Notes

Stop using remote storage.