search

canonical / prometheus-openstack-exporter

OpenStack exporter for the prometheus monitoring system
GNU General Public License v3.0
128 stars 113 forks source link

Adding the ability to specify the region name on V3 #96

Closed tcarmet closed 1 year ago

tcarmet commented 5 years ago

The region name parameter was not given to the nova, neutron and cinder API clients. We're now retrieving the env var OS_REGION_NAME and passing it through those clients.

digitalrane commented 4 years ago

Hi there, thanks for the contribution! Am I correct in understanding that this would make the region name a mandatory environment variable for the exporter to function?

tcarmet commented 4 years ago

Hello @devec0, thank you for your feedback.

I'm reviewing the code here, and I think you're right, I feel like I'm making it mandatory, and it shouldn't be.

I can take a deeper look and make it optional, if we agree on this particular point.

Pjack commented 1 year ago

This PR stall over year, therefore, I close it. Welcome to submit PR again if this enhancement is still required.