Base class implementation.

misohu commented 11 months ago

This PR implements this upstream component. Key features:

Implemented in base charm.
On every init it generates ssl files if they are not presented in the _store. These certificates are then pushed to container and the ca file is provided to webhook objects. We use similar implementation as in kserve-operators

Integration tests:

we deploy istio and istio-pilot plus the pvcviewer-charm
we try the upstream example (to match upstream testing)

i-chvets commented 11 months ago

Should we also add removal test in which we test accessibility of URL after charm is removed? Just to make sure we clean up everything.

misohu commented 11 months ago

Hi @i-chvets resolved your comments ... added integration test for remove application. I also added readme.

i-chvets commented 11 months ago

Failed integration test in local setup. Timeout on waiting for UI.

INFO     httpx:_client.py:1013 HTTP Request: PATCH https://10.1.1.124:16443/api/v1/namespaces/kubeflow-user-example-com?fieldManager=pvcviewer-operator "HTTP/1.1 200 OK"
INFO     httpx:_client.py:1013 HTTP Request: PATCH https://10.1.1.124:16443/apis/kubeflow.org/v1alpha1/namespaces/kubeflow-user-example-com/pvcviewers/pvcviewer-sample?fieldManager=pvcviewer-operator "HTTP/1.1 200 OK"
INFO     httpx:_client.py:1013 HTTP Request: PATCH https://10.1.1.124:16443/api/v1/namespaces/kubeflow-user-example-com/persistentvolumeclaims/pvcviewer-sample?fieldManager=pvcviewer-operator "HTTP/1.1 200 OK"
INFO     httpx:_client.py:1013 HTTP Request: GET https://10.1.1.124:16443/api/v1/namespaces/test-charm-fwxe/services/istio-ingressgateway-workload "HTTP/1.1 200 OK"
INFO     httpx:_client.py:1013 HTTP Request: PATCH https://10.1.1.124:16443/api/v1/namespaces/kubeflow-user-example-com?fieldManager=pvcviewer-operator "HTTP/1.1 200 OK"
INFO     httpx:_client.py:1013 HTTP Request: PATCH https://10.1.1.124:16443/apis/kubeflow.org/v1alpha1/namespaces/kubeflow-user-example-com/pvcviewers/pvcviewer-sample?fieldManager=pvcviewer-operator "HTTP/1.1 200 OK"
INFO     httpx:_client.py:1013 HTTP Request: PATCH https://10.1.1.124:16443/api/v1/namespaces/kubeflow-user-example-com/persistentvolumeclaims/pvcviewer-sample?fieldManager=pvcviewer-operator "HTTP/1.1 200 OK"
INFO     httpx:_client.py:1013 HTTP Request: GET https://10.1.1.124:16443/api/v1/namespaces/test-charm-fwxe/services/istio-ingressgateway-workload "HTTP/1.1 200 OK"
FAILED

i-chvets commented 11 months ago

Verified by creating PR https://github.com/canonical/pvcviewer-operator/pull/7

canonical / pvcviewer-operator

Base class implementation. #4