canonical / pylxd

Python module for LXD
https://pylxd.readthedocs.io/en/latest/
Apache License 2.0
256 stars 135 forks source link

Inconsistent supported python version with one specified by dependecy modules #395

Open artingithug opened 4 years ago

artingithug commented 4 years ago

Pypi of pylxd ver 2.2.10 build shows at classifier field that it supports upto python version 3.6. However, requests-toolbelt module and ws4py module, what pylxd depends on, appear to constrain python version upto 3.5.

Expected:

Actual:

Supplement info:

xnox commented 4 years ago

Note that whilst ws4py in pypi shop do not support 3.7 and up, in Debian and Ubuntu ws4py are patched for 3.7+ support.

I don't know if requests-toolbelt works or not.

jhenstridge commented 4 years ago

Note that trove classifiers are not a great way of determining the version compatibility of a packages. Many packages will just work with new versions of Python, and developers might not update the classifiers when publishing new releases.

The main concern is the ws4py dependency, right?

xnox commented 4 years ago

Correct ws4py is dead upstream, last known maintainer said they don't have time to do things. Distros have ws4py patched, but the version from pypi is broken.

Maybe you can switch requirements.txt syntax to pull ws4py from Ubuntu or Debian tarball and/or patch it, when building a part for it? As the stock one from pypi is borked.

xnox commented 4 years ago

Or for example please drop ws4py from the requirements.txt it is optional, and code works without it. And if someone has a working copy of ws4py => great, otherwise a broken one is not automatically installed for those that follow requirements.txt from pypi.